This repository was archived by the owner on Dec 25, 2022. It is now read-only.
Open
Conversation
linusg
reviewed
Oct 16, 2022
Contributor
linusg
left a comment
linusg
left a comment
There was a problem hiding this comment.
What are the modifications here, and how will we keep them in sync?
Member
|
This also doesn't add an actions pipeline to actually enforce these checks :) |
Author
Removing the SerenityOS specific checks, e.g. paths and exceptions. At the moment changes need to be synced manually. I do not know if there is a better way of doing it.
I have not worked with github actions beforehand, I wanted to place this PR first before messing around with github workflows. :^) The goal of this PR atm is to catch the issues when developing locally. |
This patch adds a modified copy of the Serenity repo style checking scripts.
This patch adds a basic pre-commit configuration.
faxe1008
force-pushed
the
introduce-meta-checks
branch
from
0ea9f5d to
892c7ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the bare minimum of Meta checks that I saw fit, making local dev a bit more comfy as issues are caught before commiting :^)